Fully annotate Field.formfield keyword args#3443
Open
brianhelba wants to merge 1 commit into
Open
Conversation
brianhelba
force-pushed
the
formfield
branch
2 times, most recently
from
06942f7 to
e721d02
Compare
brianhelba
commented
Jun 23, 2026
| srid: Any = ..., | ||
| **kwargs: Any, | ||
| ) -> forms.GeometryField: ... | ||
| ) -> forms.GeometryField | None: ... |
Contributor
Author
There was a problem hiding this comment.
Like the base class, subclasses of this are allowed to return None, even though this particular method doesn't.
brianhelba
commented
Jun 23, 2026
Comment on lines
+240
to
+242
| # The parameters form_class / choices_form_class are positional at runtime, but | ||
| # usage and docs always pass them as keyword args; additionally, all subclasses | ||
| # require them to be keyword-only, so require all usage to be keyword-only. |
sobolevn
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the suggestion by @intgr in https://github.com/typeddjango/django-stubs/pull/1778/changes#r1365630425
The removed methods have the exact same signature as the base class. Remaining subclass methods clearly note which extra parameters are added to distinguish them.
AI Policy